Merge pull request #1372 from jseminck/no-typos-fix

Fix crash for no-typos rule
jsx-eslint · Aug 15, 2017 · 60aed2e · 60aed2e
2 parents 7b305bd + fc1f873
commit 60aed2e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/rules/no-typos.js b/lib/rules/no-typos.js
@@ -66,6 +66,10 @@ module.exports = {
       },
 
       MemberExpression: function(node) {
+        if (node.parent.type !== 'AssignmentExpression') {
+          return;
+        }
+
         const relatedComponent = utils.getRelatedComponent(node);
 
         if (

diff --git a/tests/lib/rules/no-typos.js b/tests/lib/rules/no-typos.js
@@ -240,6 +240,15 @@ ruleTester.run('no-typos', rule, {
       '}'
     ].join('\n'),
     parserOptions: parserOptions
+  }, {
+    // https://github.com/yannickcr/eslint-plugin-react/issues/1353
+    code: `
+      function test(b) {
+        return a.bind(b);
+      }
+      function a() {}
+    `,
+    parserOptions: parserOptions
   }],
 
   invalid: [{
-Original file line number
+Diff line change
@@ Expand Up / @@ -66,6 +66,10 @@ module.exports = { @@
           },
           MemberExpression: function(node) {
+            if (node.parent.type !== 'AssignmentExpression') {
+              return;
+            }
             const relatedComponent = utils.getRelatedComponent(node);
             if (
@@ Expand Down @@