[Fix] boolean-prop-naming: avoid a crash with a spread prop

Fixes #3733
jsx-eslint · May 31, 2024 · a79beb3 · a79beb3
1 parent e27ef81
commit a79beb3
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,8 +7,10 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 
 ### Fixed
 * [`prop-types`]: null-check rootNode before calling getScope ([#3762][] @crnhrv)
+* [`boolean-prop-naming`]: avoid a crash with a spread prop ([#3733][] @ljharb)
 
 [#3762]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3762
+[#3733]: https://github.com/jsx-eslint/eslint-plugin-react/issues/3733
 
 ## [7.34.2] - 2024.05.24
 

diff --git a/lib/rules/boolean-prop-naming.js b/lib/rules/boolean-prop-naming.js
@@ -399,7 +399,7 @@ module.exports = {
             }
 
             if (propType) {
-              [].concat(propType).forEach((prop) => {
+              [].concat(propType).filter(Boolean).forEach((prop) => {
                 validatePropNaming(
                   component.node,
                   prop.properties || prop.members || prop.body

diff --git a/tests/lib/rules/boolean-prop-naming.js b/tests/lib/rules/boolean-prop-naming.js
@@ -415,7 +415,6 @@ ruleTester.run('boolean-prop-naming', rule, {
       `,
       options: [{ rule: '^is[A-Z]([A-Za-z0-9]?)+' }],
       features: ['ts'],
-      errors: [],
     },
     {
       code: `
@@ -426,7 +425,6 @@ ruleTester.run('boolean-prop-naming', rule, {
       `,
       options: [{ rule: '^is[A-Z]([A-Za-z0-9]?)+' }],
       features: ['types'],
-      errors: [],
     },
     {
       code: `
@@ -439,7 +437,6 @@ ruleTester.run('boolean-prop-naming', rule, {
       `,
       options: [{ rule: '(is|has)[A-Z]([A-Za-z0-9]?)+' }],
       features: ['types'],
-      errors: [],
     },
     {
       code: `
@@ -451,7 +448,6 @@ ruleTester.run('boolean-prop-naming', rule, {
       `,
       options: [{ rule: '^is[A-Z]([A-Za-z0-9]?)+' }],
       features: ['types'],
-      errors: [],
     },
     {
       code: `
@@ -465,7 +461,6 @@ ruleTester.run('boolean-prop-naming', rule, {
       `,
       options: [{ rule: '^(is|has)[A-Z]([A-Za-z0-9]?)+' }],
       features: ['types'],
-      errors: [],
     },
     {
       code: `
@@ -479,7 +474,6 @@ ruleTester.run('boolean-prop-naming', rule, {
       `,
       options: [{ rule: '^(is|has)[A-Z]([A-Za-z0-9]?)+' }],
       features: ['types'],
-      errors: [],
     },
     {
       code: `
@@ -495,7 +489,21 @@ ruleTester.run('boolean-prop-naming', rule, {
       `,
       options: [{ rule: '^(is|has)[A-Z]([A-Za-z0-9]?)+' }],
       features: ['types'],
-      errors: [],
+    },
+    {
+      code: `
+        export const DataRow = (props: { label: string; value: string; } & React.HTMLAttributes<HTMLDivElement>) => {
+            const { label, value, ...otherProps } = props;
+            return (
+                <div {...otherProps}>
+                    <span>{label}</span>
+                    <span>{value}</span>
+                </div>
+            );
+        };
+      `,
+      options: [{ rule: '(^(is|has|should|without)[A-Z]([A-Za-z0-9]?)+|disabled|required|checked|defaultChecked)' }],
+      features: ['types'],
     },
   ]),