[Refactor] function-component-definition: exit early if no type params

Co-authored-by: HenryBrown0 <26250092+HenryBrown0@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
jsx-eslint · Sep 24, 2023 · aef6e7d · aef6e7d
1 parent 0714704
commit aef6e7d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,7 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 ### Changed
 * [Refactor] `propTypes`: extract type params to var ([#3634][] @HenryBrown0)
 * [Refactor] [`boolean-prop-naming`]: invert if statement ([#3634][] @HenryBrown0)
+* [Refactor] [`function-component-definition`]: exit early if no type params ([#3634][] @HenryBrown0)
 
 [#3638]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3638
 [#3634]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3634

diff --git a/lib/rules/function-component-definition.js b/lib/rules/function-component-definition.js
@@ -33,14 +33,12 @@ const UNNAMED_FUNCTION_TEMPLATES = {
 };
 
 function hasOneUnconstrainedTypeParam(node) {
-  if (node.typeParameters) {
-    return (
-      node.typeParameters.params.length === 1
-      && !node.typeParameters.params[0].constraint
-    );
-  }
+  const nodeTypeParams = node.typeParameters;
 
-  return false;
+  return nodeTypeParams
+    && nodeTypeParams.params
+    && nodeTypeParams.params.length === 1
+    && !nodeTypeParams.params[0].constraint;
 }
 
 function hasName(node) {