Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.10.1 breaks v6.10.0 builds (related to jsx-indent) #1117

Closed
diegohaz opened this issue Mar 19, 2017 · 14 comments · Fixed by singapore/lint-condo#262
Closed

v6.10.1 breaks v6.10.0 builds (related to jsx-indent) #1117

diegohaz opened this issue Mar 19, 2017 · 14 comments · Fixed by singapore/lint-condo#262
Assignees
Labels

Comments

@diegohaz
Copy link

Error:

103:11  error  Expected indentation of 8 space characters but found 10  react/jsx-indent

Code from 103:11:
https://github.com/diegohaz/arc/blob/84ef1227b18f3d80ac6a297345ccc007ab191015/src/components/molecules/Modal/index.js#L103

On v6.10.0 it doesn't occur.

@ljharb
Copy link
Member

ljharb commented Mar 19, 2017

This also is breaking react-dates react-dates/react-dates#383

@yannickcr
Copy link
Member

Looking at it.

@ljharb
Copy link
Member

ljharb commented Mar 19, 2017

@yannickcr i'm afraid this still isn't fixed.

This code is still warning on jsx-indent, newly in 6.10+.

@ljharb ljharb reopened this Mar 19, 2017
@ljharb
Copy link
Member

ljharb commented Mar 20, 2017

(there's a number of other examples in that repo; clone at this sha and run npm install && npm run lint to see the errors)

@yannickcr
Copy link
Member

Crap, you're right. Seems to be another issue with multi-line tags. I'll made another patch release shortly. but there is a good chance it will be done tomorrow (it's getting late here).

@atkinchris
Copy link

We're still experiencing this bug with 6.10.2, with the following JSX.

<div>
    {myText} of {myOtherText} completed before something else
</div>

// Expected indentation of 12 space characters but found 1  react/jsx-indent

@vlcr
Copy link

vlcr commented Mar 20, 2017

@atkinchris I'm still experiencing problems as well.

My sample:

  <div>
    {var &&
      <span className="text">{var}</span>                                //this line works fine
    }
    {var &&
      <span className="text">{var}
      </span>                                  //this line works fine, even though it shouldn't
    }
    {var &&
      <img                              //line that throws an error, but I believe it shouldn't
        className="picture"
        alt="image"
        src={var}
      />
    }
  </div>

error Expected indentation of 8 space characters but found 10 react/jsx-indent

@freak3dot
Copy link

freak3dot commented Mar 20, 2017

Still seeing the issue with version 6.10.2 also.

Reverting to 6.9.0 works. Reverting for now.

@ljharb
Copy link
Member

ljharb commented Mar 20, 2017

@yannickcr #1118 has some extra test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

8 participants