current in this.input.current is misinterpreted as a prop

[atzec]

After update from 7.11.1 to 7.12.0 we started seeing this problem. Originally, the error occurred on a ref (e.g. this.input.current, where this.input was created in the constructor using React.createRef()), but here's a more abstract minimal example:

import React from "react";

export class D extends React.Component {

    constructor(props) {
        super(props);
        this.x = {y: "z"};
    }

    componentDidUpdate() {
        // react/prop-types: 'y' is missing in props validation
        console.log(this.x.y);
    }

}

Oddly enough, only componentDidUpdate() seems to be affected:

import React from "react";

export class D extends React.Component {

    constructor(props) {
        super(props);
        this.x = {y: "z"};
    }

    componentDidMount() {
        console.log(this.x.y); // NO error
    }

    componentDidUpdate() {
        console.log(this.x.y); // ERROR
    }

    render() {
        return this.x.y; // NO error
    }

}

(eslint 5.11.1)

[radoslawgrochowski]

  shouldComponentUpdate(nextProps, nextState) {
    return (
      nextState.disable !== this.state.disable ||
      nextState.fieldCount !== this.state.fieldCount
    );
  }

error at nextState.fieldCount and nextState.disable

[ljharb]

Not sure if this is fixed by the unreleased #2099 or #2098

[dzek69]

I can confirm this.

Using this.anything.anyName inside componentDidUpdate causes anyName to be caught as prop without propType.

Edit: @ljharb I can also confirm #2099 (commit 55e5fc1) fixes this issue.

[ljharb]

Thanks for confirming.