Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react/jsx-one-expression-per-line #2467

Closed
rhalaly opened this issue Oct 20, 2019 · 1 comment · Fixed by #2542
Closed

react/jsx-one-expression-per-line #2467

rhalaly opened this issue Oct 20, 2019 · 1 comment · Fixed by #2542

Comments

@rhalaly
Copy link

rhalaly commented Oct 20, 2019

Similar to #1775 ...

The bug with the --fix part of this rule is still there, and the PR did not fix it.

Rules

"react/jsx-one-expression-per-line": "error",
"react/jsx-indent": [
     "error",
      4
],

Original Code

return (
    <div>text</div>
);

Actual (after fix)

return (
    <div>
text
    </div>
);

Expected

return (
    <div>
        text
    </div>
);
@toshi-toma
Copy link
Contributor

I'll create the PR.

ljharb pushed a commit to toshi-toma/eslint-plugin-react that referenced this issue Jan 16, 2020
ljharb pushed a commit to toshi-toma/eslint-plugin-react that referenced this issue Jan 28, 2020
ljharb pushed a commit to toshi-toma/eslint-plugin-react that referenced this issue Feb 1, 2020
@ljharb ljharb closed this as completed in ffdf69a Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants