[jsx-sort-props] consider className as reserved props

[zhoudaxia2016]

Hello

Can we support this？

[ljharb]

Why? It's not a special prop.

[zhoudaxia2016]

My team has a rule: className must be placed before all other props
Or can I have other way to achieve the rule

[ljharb]

See https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-sort-props.md#rule-options ; you can add it in reservedFirst.

[zhoudaxia2016]

Oh， it works.Thanks
Perhaps I misconfigured before

[saimonkat]

@ljharb it's not working now

[ljharb]

@saimonkat y9ull need to elaborate; the OP fixed it by fixing their config.

[saimonkat]

@ljharb sorry, what do you mean? How can I use className in the reservedFirst prop at jsx-sort-props if it not allows it?

'react/jsx-sort-props': [
      'error',
      {
        noSortAlphabetically: true,
        shorthandLast: true,
        callbacksLast: true,
        reservedFirst: ['className'],
      },
    ],

const RESERVED_PROPS_LIST = [
  'children',
  'dangerouslySetInnerHTML',
  'key',
  'ref',
];

[ljharb]

You're right, only those 4 can be in reservedFirst. The rule doesn't actually support arbitrary orders beyond what's configurable, by design.