Fix nextProps false positive in no-unused-prop-types #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Mar 12, 2017
lib/rules/no-unused-prop-types.js
Outdated
| @@ -17,7 +17,7 @@ var annotations = require('../util/annotations'); | |||
| // Constants | |||
| // ------------------------------------------------------------------------------ | |||
|
|
|||
| var DIRECT_PROPS_REGEX = /^props\s*(\.|\[)/; | |||
| var DIRECT_PROPS_REGEX = /^(props|nextProps)\s*(\.|\[)/; | |||
There was a problem hiding this comment.
this seems to suggest that there will be places that props and nextProps are interchangeable - that doesn't seem right to me.
There was a problem hiding this comment.
I did exactly like the prop-types rules. It means that this one is wrong too.
What do you suggest? This regex is only used one time.
There was a problem hiding this comment.
I pushed a try. I split the regex into 2 variables. It leads to more conditions. Tell me if you prefer this version.
| ' }', | ||
| '}' | ||
| ].join('\n'), | ||
| parser: 'babel-eslint' |
There was a problem hiding this comment.
there's no need to use babel-eslint here; let's just use normal Hello.propTypes = , and use the default parser
Kerumen
force-pushed
the
master
branch
2 times, most recently
from
1dfff04 to
6986798
Compare
iegik
added a commit
to iegik/react-native-grid-component
that referenced
this pull request
Mar 12, 2017
iegik
added a commit
to iegik/react-native-grid-component
that referenced
this pull request
Mar 12, 2017
ljharb
approved these changes
Mar 12, 2017
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1079
I did the same comparisons as the
prop-typesrules (https://github.com/yannickcr/eslint-plugin-react/blob/b64648521f9a7949eef4cd1a210768e906b4f3d1/lib/rules/prop-types.js#L130) for theno-unused-prop-typesrule.This way they both handle nextProps identically.
I also borrowed the test case from #1105.