Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display-name false positive for React.memo #2109

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

jomasti
Copy link
Contributor

@jomasti jomasti commented Jan 3, 2019

This will only consider the React memo/forwardRef wrappers to be components themselves if they are wrapping a FunctionExpression/ArrowFunctionExpression directly. In the issue code sample, the normal function component will be picked up as a component as usual.

Resolves #2105

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great, thanks!

@ljharb ljharb added the bug label Jan 3, 2019
@ljharb ljharb merged commit a86b339 into jsx-eslint:master Jan 3, 2019
@jomasti jomasti deleted the issue-2105 branch January 3, 2019 13:33
This was referenced Jan 4, 2019
@ghost ghost mentioned this pull request Jan 12, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants