-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] update configuration URL #3582
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3582 +/- ##
=======================================
Coverage 97.62% 97.62%
=======================================
Files 132 132
Lines 9295 9295
Branches 3400 3400
=======================================
Hits 9074 9074
Misses 221 221 |
Well, that's a weird requirement, but here we go. |
Thanks! Instead of changing the outputted URL, can we add |
That's a better idea. I sure can do it like that. Lemme do some clickety-click and get back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
a93e1a2
to
be3eead
Compare
it's checked by default, and it allows maintainers to rebase and adjust your PR branch as needed to land it. I've always found it weird that people sometimes un check it ¯\_(ツ)_/¯ |
Thanks a lot ^_^ |
Hi,
When I run
eslint
on some React files, this is what I get:And the given URL resolves the repository, but doesn't scroll to the anchored place because of this change: 17858be#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R20
This PR is here to fix the URL and point the correct location.
I hope this makes sense. Thanks in advance for your consideration.
Best,
G.