-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] sort-prop-types
: ensure sort-prop-types respects noSortAlphabetically
#3610
[Fix] sort-prop-types
: ensure sort-prop-types respects noSortAlphabetically
#3610
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3610 +/- ##
==========================================
+ Coverage 97.62% 97.63% +0.01%
==========================================
Files 132 132
Lines 9288 9289 +1
Branches 3394 3395 +1
==========================================
+ Hits 9067 9069 +2
+ Misses 221 220 -1
|
Duplicate of #3609 - which means both must now stay open so I can keep them in sync and land them together. |
63e88c1
to
3c11201
Compare
First of all, I really appreciate for the code review. It's my first time to participate in open source, so I closed the first pr and created a new pr because I didn't seem to have properly kept the commit convention with other people and didn't write the test code properly in the first pr. Thank you for caring me! |
@caesar1030 no problem - in the future, it's best to reuse the PR rather than making a new one (but also, to not make a PR from master/main). |
@ljharb thank you! I'll be careful not to repeat the same mistake in the next pr :-) |
Fixes #3591