Prevent string literals being used in ref attributes #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the rule. 2 minors things though:
Beside that I'm totally ok to add this rule :) |
|
Sure! I'll add them tomorrow :) |
|
@yannickcr I've implemented your suggestions, let me know if there is anything else :) |
|
Just missing the title in docs/no-string-refs.md |
Add check for string usage in ref attributes Add unit tests Add docs Improve docs Improve tests Improve docs Add rule to index.js Fix linting errors Rename from no-refs to no-string-refs Update ESLint project readme Add titles
|
@yannickcr Sorry, my latest change to adding titles was not pushed correctly, should be good now and also I squashed all commits :) |
yannickcr
added a commit
that referenced
this pull request
Dec 22, 2015
Add no-string-refs rule (fixes #341)
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, the idea in #341 was to check if references in
this.refsexist. Based on further discussion it was suggested to define a rule to disallow using string literals in reference properties.