-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] no-invalid-html-attribute
: add support for apple-touch-startup-image
rel
attributes in link
tags
#3638
[New] no-invalid-html-attribute
: add support for apple-touch-startup-image
rel
attributes in link
tags
#3638
Conversation
…up-image` `rel` attributes in `link` tags
Codecov Report
@@ Coverage Diff @@
## master #3638 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 132 132
Lines 9360 9360
Branches 3427 3427
=======================================
Hits 9140 9140
Misses 220 220
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
no-invalid-html-attribute
: add support for apple-touch-startup-image
rel
attributes in link
tags
The failing tests are unrelated to this PR; I'll fix them on master after landing this. |
Hey guys, sorry to be bothering, I don't know how the releases works here. Just pinging to know if we have a prevision when this fix will become to a release. |
There’s no timeline; it’ll be included in the next release. |
Thanks! |
Currently this attribute fails on the latest version:
According to the docs the accepted values for this rule come from MDN, and MDN states that this value is non-standard but not disallowed, the same as
apple-touch-icon
.If I am incorrect here please let me know.
To test this I've added a generic example as seen in Apple's own documentation as well as a longer example more like something that a PWA asset generator would give you (which is recommended by web.dev).