-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] prop-types
: handle nested forwardRef + memo
#3679
Conversation
Fixes jsx-eslint#3521. Co-authored-by: 김상두 <puki4416@gmail.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3679 +/- ##
=======================================
Coverage 97.74% 97.74%
=======================================
Files 132 132
Lines 9409 9420 +11
Branches 3449 3456 +7
=======================================
+ Hits 9197 9208 +11
Misses 212 212 ☔ View full report in Codecov by Sentry. |
f41b6f3
to
0302a2f
Compare
prop-types
: handle nested forwardRef + memo
With the latest rebase, some tests are failing. Can you update to this commit and take a look? |
@ljharb yes, so I fix the failed test code but almost code is changed. so may be reivew is nessesary and some Tests are fail because node install fail. i don't know why it is fail. please tell me hint to fix it. (and Automatic Rebase) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have to worry about the automatic rebase check. The PR now lacks any tests, is that intentional?
no, it is not intentional. it's my mistake. perhaps i did pull at local codebase, that test code is deleted. |
c1c273c
to
88f7f09
Compare
Fix #3521