-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] jsx-closing-tag-location
: add line-aligned
option
#3777
[New] jsx-closing-tag-location
: add line-aligned
option
#3777
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3777 +/- ##
==========================================
- Coverage 97.77% 97.76% -0.01%
==========================================
Files 135 135
Lines 9655 9680 +25
Branches 3500 3515 +15
==========================================
+ Hits 9440 9464 +24
- Misses 215 216 +1 ☔ View full report in Codecov by Sentry. |
446dc74
to
a1a3464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good! I've rebased it. Only thing left is the uncovered lines.
a1a3464
to
b381547
Compare
c5c7494
to
d0f6512
Compare
d0f6512
to
7be3ee5
Compare
looks like tests are failing |
39b8fed
to
2fdf0b4
Compare
5ff60fb
to
c58f04b
Compare
Fixes #3740
I added new options to
jsx-closing-tag-location
:line-aligned
andtag-aligned (default)
.With the
line-aligned
option, the following code would be accepted:Users can use the
tag-aligned
option to ensure that the following code is accepted:What I did:
Please let me know if there are any improvements needed. I am happy to fix them!
I am honored to contribute to this project.