Skip to content

Commit

Permalink
Fix/fix readme (#289)
Browse files Browse the repository at this point in the history
* Add kube2iam to control AWS IAM policy access (#216)

* kube2iam chart

* set hostNetwork at the spec level

* fixes from code review h/t @mgoodness

* cleanup/style

* linter, host needs to be a dictionary

* move kube2iam to stable

* kube2iam: Don't quote .Values.host.interface; it breaks iptables wildcard support (#387)

* .Values.host.interface shouldn't be quoted

In some network configurations we have to handle traffic to the metadata api
from multiple interfaces - typically the node side of a veth pair, where the
other side lives inside a Pod's network namespace.  We could use the wildcard
functionality in iptables to do this, but setting `host.interface: veth+` in
this chart doesn't work.

This is because the parameter is quoted in the DaemonSet template and kube2iam
ends up sending the parameter it receives on the command-line directly to
`execvp("iptables", ...)`, which means that the parameter stays quoted all the
way into the actual iptables rule. So you end up with a rule that looks like
this:

```shell
iptables -t nat -S PREROUTING | grep 169.254.169.254
-A PREROUTING -d 169.254.169.254/32 -i "veth+" -p tcp -m tcp --dport 80 -j DNAT --to-destination 10.0.0.1:8181
```

this rule only matches an interface named exactly veth+ since the wildcard
character apparently isn't expanded when the interface name is quoted. If we
remove the quoting we can support iptables wildcards and I don't see why it
shouldn't work for exact matching the interface name still.

* Bump version

* Missing chart in helm install statement (#598)

* Missing chart in helm install statement

Usage: (v2.1.3)
  helm install [CHART] [flags]

* Include chart in install statement
* Fix set flag to use strings as required

* Trim to single line set option

* Managed to stomp the package during rebase

* Consistency of install package

* [stable/kube2iam] v0.2.0 (#615)

* Added .helmignore
* Updated common labels per proposed best practices
* Split image repository and tag
* Don't quote host interface argument (fix)
* Added verbose option
* Docs
* YAML formatting
* Removed default function in favor of values.yaml

* [stable/kube2iam] No default resources (#682)

* Pedantic commenting

* No default resources

* Semver-compliant

* [stable/kube2iam] Rolling updates (#1276)

* [stable/kube2iam] Rolling updates

Also bump to latest image version

* Allow further update strategies

* [stable/kube2iam]: add rbac support (#1286)

* add rbac support

* solve and edge-case when turning off rbac

* Use consistent whitespace in template placeholders (#1437)

Use consistent whitespace in template placeholders

* [stable/kube2iam] fix: update default image version to latest (#1492)

* fix: update default image version to latest

* Bump chart version

* [stable/kube2iam] Allow user-managed RBAC (#1504)

* Allow user-managed RBAC

* Add namespaces to ClusterRole

* [stable/kube2iam] Update strategy (#1510)

* Set UpdateStrategy using .Capabilities

* Bump chart version

* Support Helm release name = chart name (#1588)

* Use latest kube2iam (#1825)

* [stable/kube2iam] Add ability to configure node tolerations (#1829)

* Add podLabels (#1920)

* [stable/kube2iam] #1785 namespace defined templates with chart name (#2132)

* stable/kube2iam: added support for aws access keys (#2675)

Added a secret resource to allow setting AWS access keys and region

* [stable/kube2iam] Bump to version 0.9.0 (#3249)

* [stable/kube2iam] Add liveness probe (#3400)

* Add liveness check so kube takes care of kube2iam in the event of any issues

* Configure --app-port to remain consistent with Helm chart value of .host.port

* Bump minor version

* Remove option to disable liveness probe

* Add support for boolean flags via extraArgs (#3792)

* typo:fix tables to table  (#4346)

* patch3

patch3

* patch-2 tables

patch-2 tables

* Added the possibility to specify affinity options to kube2iam chart (#4203)

* kube2iam update to 0.10.0; fixes 5th generation instance types and cr… (#4535)

* kube2iam update to 0.10.0; fixes 5th generation instance types and cross namespace permissions

* kube2iam adding home to Chart.yaml

* Fix for version comparison from strings to semver (#4600)

* Fix for version comparison from strings to semver

See #3002 for more detail

* Updating maintainers to github ids

* Fixing " error due to wrong " character

* Include pre-releases in the semver ranges

This is important when testing against alpha and beta builds of
Kubernetes along with environments that use pre-releases to denote
things other than pre-releases (e.g., gke denotes the environment
with a pre-releases)

* make liveness probe conditional (#4612)

* Show tolerations options in  README.md (#4830)

* Update README.md

* Incrementing the chart version

* [stable/kube2iam] Support extra container environment variables (#5091)

* Support extra container environment variables.

* [stable/kube2iam] Ensure extra container environment variable values are quoted.

* [kube2iam] Add node flag to limit relevant pods (#5652)

* [kube2iam] Add node flag to limit relevant pods

* Update Chart.yaml

* added missing get verb (#8667)

* added missing get verb

Signed-off-by: Amir Kibbar <amir.kibbar@gmail.com>

* bumped version

Signed-off-by: Amir Kibbar <amir.kibbar@gmail.com>

* add priorityClassName, upgrade kube2iam (#9092)

Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>

* Adds Prometheus ServiceMonitor resource to kube2iam (#11416)

Changes:
 - Adds ServiceMonitor & Service resources for use with Prometheus Operator.
 - Allows configuring the metrics port option of kube2iam and will
 configure the new named port on the DaemonSet when applicable.
 - Adds docs for all new config params

Bonus:
 - Adds missing docs for `host.port` config param

Signed-off-by: Will Frew <will.frew1@gmail.com>

* add apiVersion (#13801)

Signed-off-by: Carlos Panato <ctadeu@gmail.com>

* [stable/kube2iam] Fix issue when changing kube2iam host port (#13729)

does not change metrics port and requires second custom port

Signed-off-by: George Kaz <egeorgekaz@gmail.com>

* [stable/kube2iam] Upgrade version, Add prometheus service annotations (#15626)

* Upgrade Kube2iam, Add prometheus service annotations

Signed-off-by: Fabio Todaro <fbregist@gmail.com>

* Update README

Signed-off-by: Fabio Todaro <fbregist@gmail.com>

* [stable/kube2iam] Use labels recommended by Helm (#15700)

See https://helm.sh/docs/chart_best_practices/#standard-labels

Since the DaemonSet's selector is immutable, this is breaking change and will require a deletion and recreation, hence the major version bump.

Signed-off-by: Peter Rifel <pgrifel@gmail.com>

* [stable/kube2iam] Update version in documentation (#16092)

* [stable/kube2iam] Update version in documentation

Change version from 0.10.4 to 0.10.7

Signed-off-by: Nicolas Vanheuverzwijn <nicolas.vanheu@gmail.com>

* Bump chart version from 2.0.0 to 2.0.1

Signed-off-by: Nicolas Vanheuverzwijn <nicolas.vanheu@gmail.com>

* [stable/kube2iam] corrects labels in notes to new format (#16703)

Signed-off-by: Dennis Webb <dennis@bluesentryit.com>

* Add in imagePullSecrets config for kube2iam chart (#18815)

Signed-off-by: Benjamin Farley <benalfarley@gmail.com>

* [stable/kube2iam] Update the kube2iam apiVersion for k8s 1.16 compatibility (#18784)

* [stable/kube2iam] Update the kube2iam apiVersion for k8s 1.16 compatibility

Signed-off-by: Mike Tougeron <tougeron@adobe.com>

* [stable/kube2iam] fix the selector

Signed-off-by: Mike Tougeron <tougeron@adobe.com>

* [stable/kube2iam] Allow setting a custom secret name to use for AWS credentials (#21265)

* Allow setting a custom secret name to use for AWS credentials in the event that the secret is populated from outside of helm for security purposes

Signed-off-by: Mike Tougeron <tougeron@adobe.com>

* [stable/kube2iam] call the variable existingSecret

Signed-off-by: Mike Tougeron <tougeron@adobe.com>

* Bump minor version for new feature

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>

Co-authored-by: Reinhard Nägele <unguiculus@gmail.com>

* [stable/kube2iam] add podsecuritypolicy object to the chart (#22074)

Signed-off-by: Yannick Kint <yannick.kint@gmail.com>

* [stable/kube2iam] bump kube2iam image and appVersion to v0.10.9 (#22333)

kube2iam v0.10.9 supports 1.17.3 due to client-go version upgrades

Signed-off-by: Marius Voila <myself@mariusv.com>

* [kube2iam] - add labels to ServiceMonitor (#21605)

Signed-off-by: Alex Williams <alex.williams@skyscanner.net>

* [stable/kube2iam] allow to customize liveness probe configuration (#22717)

* allow to customise livenessProbe parameters

Signed-off-by: Luigi Tagliamonte <luigi.tagliamonte@doordash.com>

* bump chart version

Signed-off-by: Luigi Tagliamonte <luigi.tagliamonte@doordash.com>

* document variables in the README

Signed-off-by: Luigi Tagliamonte <luigi.tagliamonte@doordash.com>

* [stable/kube2iam] add repo archive notice (#24143)

Signed-off-by: Scott Rigby <scott@r6by.com>

* fix README

fixes #288

Signed-off-by: Marius Voila <myself@mariusv.com>

* Update README.md

Co-authored-by: Michael Haselton <icereval@gmail.com>
Co-authored-by: Øyvind Ingebrigtsen Øvergaard <oyvind.overgaard@gmail.com>
Co-authored-by: Vlad <VDuda@users.noreply.github.com>
Co-authored-by: Michael Goodness <mgoodness@gmail.com>
Co-authored-by: Chris Knowles <c-knowles@users.noreply.github.com>
Co-authored-by: Sam Clinckspoor <sam.clinckspoor@gmail.com>
Co-authored-by: Frederic Hemberger <mail@frederic-hemberger.de>
Co-authored-by: Frode Egeland <egeland@gmail.com>
Co-authored-by: Victor Unegbu <victor@unegbu.com>
Co-authored-by: Kevin Schumacher <kevinmichaelschumacher@gmail.com>
Co-authored-by: Jesus Rafael Carrillo <jesuscarrillo8@gmail.com>
Co-authored-by: Erick Tryzelaar <erick.tryzelaar@gmail.com>
Co-authored-by: Dan Gorst <dgorst@expedia.com>
Co-authored-by: Peter Rifel <rifelpet@users.noreply.github.com>
Co-authored-by: yulng <wei.yang@daocloud.io>
Co-authored-by: Maxime VISONNEAU <maxime.visonneau@gmail.com>
Co-authored-by: Shane Starcher <shanestarcher@gmail.com>
Co-authored-by: Matt Farina <matt@mattfarina.com>
Co-authored-by: Khris Richardson <khris.richardson@gmail.com>
Co-authored-by: Jakob <info@jakobniggel.de>
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
Co-authored-by: Daren Desjardins <darend@gmail.com>
Co-authored-by: Amir <amirkibbar@users.noreply.github.com>
Co-authored-by: Taehyun Kim <kgyoo8232@gmail.com>
Co-authored-by: Will Frew <will.frew1@gmail.com>
Co-authored-by: Carlos Tadeu Panato Junior <ctadeu@gmail.com>
Co-authored-by: georgekaz <egeorgekaz@gmail.com>
Co-authored-by: Fabio Todaro <fbregist@gmail.com>
Co-authored-by: Nicolas Vanheuverzwijn <nicolas.vanheu@gmail.com>
Co-authored-by: Dennis Webb <dennis@bluesentryit.com>
Co-authored-by: Benjamin Farley <benalfarley@gmail.com>
Co-authored-by: Mike Tougeron <mtougeron@users.noreply.github.com>
Co-authored-by: Reinhard Nägele <unguiculus@gmail.com>
Co-authored-by: KYannick <KYannick@users.noreply.github.com>
Co-authored-by: Alex Williams <alex.williams@skyscanner.net>
Co-authored-by: Luigi Tagliamonte <51684360+ltagliamonte-dd@users.noreply.github.com>
Co-authored-by: Scott Rigby <scott@r6by.com>
Co-authored-by: Jerome Touffe-Blin <jtblin@gmail.com>
  • Loading branch information
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
1 change: 0 additions & 1 deletion charts/kube2iam/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,4 @@ sources:
maintainers:
- name: mariusv
email: myself@mariusv.com

engine: gotpl
7 changes: 3 additions & 4 deletions charts/kube2iam/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Installs [kube2iam](https://github.com/jtblin/kube2iam) to provide IAM credentia
## TL;DR;

```console
$ helm install stable/kube2iam
$ helm install kube2iam/kube2iam
```

## Introduction
Expand All @@ -21,9 +21,8 @@ This chart bootstraps a [kube2iam](https://github.com/jtblin/kube2iam) deploymen
To install the chart with the release name `my-release`:

```console
$ helm repo add kube2iam https://buildkite.github.io/charts/
$ helm repo update
$ helm install stable/kube2iam --name my-release
$ helm repo add kube2iam https://jtblin.github.io/kube2iam/
$ helm install kube2iam/kube2iam --name my-release
```

The command deploys kube2iam on the Kubernetes cluster in the default configuration. The [configuration](#configuration) section lists the parameters that can be configured during installation.
Expand Down

0 comments on commit bb97695

Please sign in to comment.