Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons are not aligned after rename file #34

Open
conao3 opened this issue Mar 17, 2020 · 6 comments
Open

Icons are not aligned after rename file #34

conao3 opened this issue Mar 17, 2020 · 6 comments

Comments

@conao3
Copy link
Contributor

conao3 commented Mar 17, 2020

Ref: #24 (comment)

@conao3 I think there are issues here when renaming a file. When I rename a file the icon ends up on the far left.

@seagle0128
Copy link

seagle0128 commented Mar 17, 2020

Same issue while creating a new file or directory (+).

Updated:
I can confirm this solution works well.

    (advice-add 'dired-do-create-files :around #'all-the-icons-dired--refresh-advice)
    (advice-add 'dired-create-directory :around #'all-the-icons-dired--refresh-advice)

@conao3 conao3 changed the title Icon is broken when rename file Icons are not aligned after rename file Mar 20, 2020
@shingo256
Copy link

Hi,

I encountered this issue as well when renaming a file, and found that below two lines look like resolving it.

       (advice-add 'dired-add-entry :around #'all-the-icons-dired--refresh-advice)
       (advice-add 'dired-remove-entry :around #'all-the-icons-dired--refresh-advice)

Hope it would be incorporated in all-the-icons-dired--setup.

@seagle0128
Copy link

I think this issue can be closed.

@conao3
Copy link
Contributor Author

conao3 commented May 11, 2021

Sorry, I've been away from this issue for a bit.
Thanks, suggestion. Has this issue been gone, @seagle0128 ?

@seagle0128
Copy link

@conao3 I took a quick look at the codes in this repo. The issue still exists, and the repo seems not to be maintained. I download the package from melpa, the repo has been changed to https://github.com/wyuenho/all-the-icons-dired. This issue has been fix in the forked repo.

@conao3
Copy link
Contributor Author

conao3 commented May 12, 2021

Thanks. Then I'll leave the issue open for the owner of this repository.
I hadn't updated the local all-the-icons-dired. Thanks for letting me know that!

ilmotta added a commit to ilmotta/dotemacs that referenced this issue Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants