Init/basic encryption #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified vault creation/updates to use a PouchDB attachment rather than key-value - Added `--in-memory` CLI arg
- Replaced abstract methods in `CommandServer` with concrete implementations - Moved shell-specific methods to `ShellCommandServer`
- Added `readline` interface that can be silenced - Added `encryptionKey` to interface for vault creation
- Added `configurePlugins` function to attach plugins and do type assertions - Modified database types to incorporate plugin types
- Fixed a bug where syncing with remote vault was cleartext - Fix: use specialized plugin function instead of intercepting contents - Added `getDerivedKey` method to share between commands - Changed key to be a required parameter for `VaultService#onCreateVault`
- Added `vault login` to reset password - Added friendlier error message on failure to decrypt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.