Correct installation method

[graysky2]

What is the correct method to package this without using pip3?
Manual installation? Where should policies go? Is tox.ini needed? Other files needed? Down the road, a Makefile would be nice or a setup script of some kind.

  install -Dm755 ssh-audit.py /usr/bin/ssh-audit
  install -Dm644 ssh-audit.1 /usr/share/man/man1/ssh-audit.1
  install -Dm644 LICENSE /usr/share/licenses/ssh-audit/LICENSE

[jtesta]

What is the correct method to package this without using pip3? Manual installation?

Yes, unfortunately there is no way to install the project locally in a clean manner at this time (I inherited maintenance from the original author, and I'm still working on it). This is being tracked in issue #46 (which may be dependent on #47). I'll be fixing these as soon as I can.

Where should policies go?

They should be in a folder named "policies" relative to where ssh-audit.py is. In other words, if you have /folder1/folder2/ssh-audit.py, then they should be in /folder1/folder2/policies/.

Once issue #46 is closed, there will probably be a better solution.

Is tox.ini needed?

Not for installation. That's used only for testing.

Other files needed?

Nope. Only ssh-audit.py and the contents of the policies/ directory are needed.

install -Dm755 ssh-audit.py /usr/bin/ssh-audit

This would require that the policies folder be in /usr/bin/policies/. Personally, I wouldn't be a fan of that. Instead, perhaps add a temporary Bash alias until #46 is resolved? This would work in the short term: alias ssh-audit="python3 /path/to/ssh-audit.py"

[graysky2]

@jtesta - Thanks, Joe. I'll just package to /opt/ssh-audit/ for Arch Linux, see: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=ssh-audit

EDIT: a wrapper is more generic than an alias, credit to reprograph, see: https://aur.archlinux.org/packages/ssh-audit/#comment-768022

[mpolanski]

In Alpine Linux I patched the code so the policy configurations reside in /usr/share/ssh-audit/policies: https://git.alpinelinux.org/aports/commit/?id=91a424eb0ea2098ac6e7a3de83c6c9d91622ef26

[graysky2]

@mpolanski - Send a PR to @jtesta

[jtesta]

@mpolanski @graysky I'm actually considering getting rid of the built-in policy files entirely in favor of including the data in a Python struct. This would make life easier for package maintainers (of which I am one too: for PyPI, Snap, and Windows). And re-organizing the project (#46 & #47) would fix the rest of the issues we all have. I hope to have that done within the next month.

…

On 9/30/20 2:29 PM, graysky wrote: @mpolanski <https://github.com/mpolanski> - Send a PR to @jtesta <https://github.com/jtesta> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#67 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWYA6YYEZI3APNBNEGHEDTSIN2JHANCNFSM4R5PLMMA>.

-- Joseph S. Testa II Founder & Principal Security Consultant Positron Security

[mpolanski]

@graysky2 My patch would break using policy files when ssh-audit is not system-wide installed, so I only patched it for Alpine.