Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: ensure static resource destination differs from each of the sources #56

Closed
jthegedus opened this issue May 12, 2021 · 4 comments · Fixed by #97
Closed

bug: ensure static resource destination differs from each of the sources #56

jthegedus opened this issue May 12, 2021 · 4 comments · Fixed by #97
Labels
bug Something isn't working released

Comments

@jthegedus
Copy link
Owner

Describe the bug

This adapter takes the contents of svelte.config.js:kit.files.assets (default static) and .svelte-kit/output/client/** and outputs them to firebase.json:hosting.public.

We should ensure that svelte.config.js:kit.files.assets is != firebase.json:hosting.public.

An example of this configuration is in #55
@jthegedus jthegedus added the bug Something isn't working label May 12, 2021
This was referenced May 12, 2021
Closed
Closed
@jthegedus
Copy link
Owner Author

Workaround to sveltejs/kit#1435 is to import the SvelteKit config and check the value if it's provided or assume the default.

@jthegedus jthegedus mentioned this issue May 13, 2021
Merged
@jthegedus jthegedus reopened this May 13, 2021
@jthegedus
Copy link
Owner Author

jthegedus commented May 13, 2021 •
edited
Loading

Solved in #65

Though this has a released workaround, an upstream solution is preferable.

@jthegedus jthegedus added the external dependency Relies on an external/upstream tool label May 16, 2021
@jthegedus jthegedus changed the title Ensure static resource destination differs from each of the sources bug: ensure static resource destination differs from each of the sources May 16, 2021
@jthegedus
Copy link
Owner Author

Ideal solve is using the provided config from this PR - sveltejs/kit#1559

@jthegedus jthegedus removed the external dependency Relies on an external/upstream tool label May 28, 2021
@jthegedus jthegedus mentioned this issue May 30, 2021
Merged
3 tasks
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 0.8.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use SK computed config to determine if static dirs differ jthegedus/svelte-adapter-firebase
1 participant
@jthegedus