feat: pass validated svelte config to adapters #1559
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass validated Svelte config to Adapters.
As vaguely discussed in #1435 and #1436 adapters may need the svelte config settings, but currently must parse the files themselves, which is brittle and unnecessary.
An example of this need comes from adapters reading specific cloud provider config to determine input and output dirs. The Firebase adapter reads the
firebase.json
file to determine the output dir for the static assets, but by default this ispublic
and so conflicts with the default ofkit.files.assets
. The adapter checks that these are different, but must first read the svelte config to determine the actual value ofsvelte.config.js:kit.files.assets
and deal with it not being listed because we are reading the object before SvelteKit defaults are applied etc.Closes #1435
Following the contribution guide,
pnpm i
changed the lockfile 🤷Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
Changesets
pnpx changeset
and following the prompts