Allow filling rectangles and ellipsis #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an option on top of existing brush types, to allow for filled shapes in addition to non-filled ones. Signed-off-by: flow <flowlnlnln@gmail.com>
This makes it similar to the rectangle draw function. Signed-off-by: flow <flowlnlnln@gmail.com>
Prevents confusion when using tools that are not affected by this setting Signed-off-by: flow <flowlnlnln@gmail.com>
Signed-off-by: flow <flowlnlnln@gmail.com>
This is a bit more intuitive i think. Signed-off-by: flow <flowlnlnln@gmail.com>
Signed-off-by: flow <flowlnlnln@gmail.com>
|
I like it and I would love to see it merged! However, I have two concerns:
|
|
I used a toggle button instead of a checkbox because that's what other "toggle-able" UI elements (they'd actually be more akin to radio buttons instead of checkboxes, but the logic still applies i think) in the UI currently use, so I followed for consistency. For the highlighting, I would think either a field like 'Line Width' and 'Text Size', or a slider thing, could work for selecting an alpha value. As you've said though, that's not really in the scope of these changes, so maybe it could be done at some later point in time 🙂 |
|
Thank you @flowln . It's looking good. I will squash all commits into one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #120
This adds an option on top of existing brush types, to allow for filled shapes in addition to non-filled ones.
I tried to follow the surrounding style as much as possible, but let me know if something isn't quite right 😅