Switch from updating to patching the target #187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the race condition for target resources that can be changed during CPA operations:
One of the common reasons for this issue is
status.availableReplicas
field being updated multiple times a second in large churning Deployments. Each time resource changes Kubernetes updatesmetadata.resourceVersion
and rejects the update if resource versions do not match.Switching to patching only the replica count helps to avoid the issue altogether. This patch should work for all supported target resource types.