Replace IndexOrdinalsFieldData#getOrdinalMap with more targeted methods. #2

jtibshirani · 2019-04-12T01:34:36Z

This commit stops exposing OrdinalMap in favor of a more tightly scoped method
to retrieve global ordinals. It also introduces a new interface
ConcreteOrdinalsFieldData so that HasChildQueryBuilder is able to get
ahold of the concrete OrdinalMap.

This commit stops exposing OrdinalMap in favor of a more tightly scoped method to retrieve global ordinals. It also introduces a new interface ConcreteOrdinalsFieldData so that HasChildQueryBuilder is able to get ahold of the concrete OrdinalMap.

jtibshirani · 2019-04-12T01:37:29Z

server/src/main/java/org/elasticsearch/index/fielddata/ConcreteOrdinalsFieldData.java

+
+import org.apache.lucene.index.OrdinalMap;
+
+public interface ConcreteOrdinalsFieldData extends IndexOrdinalsFieldData {


This isn't a good name, which suggests the design may not make sense :)

* * StartsWith is case sensitive aware * Added case sensitivity to EQL configuration * case_sensitive parameter can be specified when running queries (default is case insensitive) * Added STARTS_WITH function to SQL as well * Add case sensitive aware queryfolder tests * Address reviews * Address review #2

…astic#69765) Previously we did not resolve the attributes recursively which meant that if a field or expression was re-aliased multiple times (through multiple levels of subqueries), the aliases were only resolved one level down. This led to failed query translation because `ReferenceAttribute`s were pointing to non-existing attributes during query translation. For example the query ```sql SELECT i AS j FROM ( SELECT int AS i FROM test) ORDER BY j ``` failed during translation because the `OrderBy` resolved the `j` ReferenceAttribute to another `i` ReferenceAttribute that was later removed by an Optimization: ``` OrderBy[[Order[j{r}#4,ASC,LAST]]] ! OrderBy[[Order[i{r}#2,ASC,LAST]]] \_Project[[j]] = \_Project[[j]] \_Project[[i]] ! \_EsRelation[test][date{f}#6, some{f}#7, some.string{f}#8, some.string..] \_EsRelation[test][date{f}#6, some{f}#7, some.string{f}#8, some.string..] ! ``` By resolving the `Attributes` recursively both `j{r}` and `i{r}` will resolve to `test.int{f}` above: ``` OrderBy[[Order[test.int{f}elastic#22,ASC,LAST]]] = OrderBy[[Order[test.int{f}elastic#22,ASC,LAST]]] \_Project[[j]] = \_Project[[j]] \_Project[[i]] ! \_EsRelation[test][date{f}#6, some{f}#7, some.string{f}#8, some.string..] \_EsRelation[test][date{f}#6, some{f}#7, some.string{f}#8, some.string..] ! ``` The scope of recursive resolution depends on how the `AttributeMap` is constructed and populated. Fixes elastic#67237

jtibshirani force-pushed the ordinals-field-data branch from 3f1e487 to f922626 Compare April 12, 2019 01:35

jtibshirani commented Apr 12, 2019

View reviewed changes

jtibshirani closed this Apr 16, 2019

jtibshirani deleted the ordinals-field-data branch April 16, 2019 16:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace IndexOrdinalsFieldData#getOrdinalMap with more targeted methods. #2

Replace IndexOrdinalsFieldData#getOrdinalMap with more targeted methods. #2

jtibshirani commented Apr 12, 2019

jtibshirani Apr 12, 2019


		import org.apache.lucene.index.OrdinalMap;

		public interface ConcreteOrdinalsFieldData extends IndexOrdinalsFieldData {

Replace IndexOrdinalsFieldData#getOrdinalMap with more targeted methods. #2

Replace IndexOrdinalsFieldData#getOrdinalMap with more targeted methods. #2

Conversation

jtibshirani commented Apr 12, 2019

jtibshirani Apr 12, 2019

Choose a reason for hiding this comment