Roomsetting, Paymentlist #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GBS-Skile
requested changes
Jun 4, 2019
frontend/src/store/Room/reducer.js
Outdated
| @@ -19,6 +20,10 @@ import { ROOM_CREATE_SUCCESS } from './actions'; | |||
| ...state, | |||
| roomname: action.roomname, | |||
| } | |||
| case ROOM_SETTING_REQUEST: | |||
| return{ | |||
| initialState | |||
There was a problem hiding this comment.
return { initialState } 대신 return { ...initialState} 구문을 사용해야합니다
initialState는 object이기 때문에 지금 표현과 같이 쓰면 중첩된 object가 만들어집니다
| <Block> | ||
| <List> | ||
| { | ||
| paymentlist & paymentlist.map( |
There was a problem hiding this comment.
&가 아니라 &&여야 short circuit evaluation이 작동합니다.
(저렇게되면 paymentlist가 undefined일때도 좌항의 .map 함수가 실행되어 ReferenceError가 발생할 것입니다.)
frontend/src/components/App.js
Outdated
| @@ -28,6 +28,8 @@ const App = () => { | |||
| <Route path="/user/create_room/" component={RoomCreatePage} /> | |||
| <Route path="/user/:room/entrance/" component={EntrancePage} /> | |||
| <Route path="/room/" component={RoomPage} /> | |||
| <Route path="/user/:room/setting/" component={RoomSettingPage} /> | |||
| <Route path="/user/:room/payment_list/" component={PaymentListPage} /> | |||
There was a problem hiding this comment.
의미상 /user/ 말고 /room/접두사가 붙는게 더 합당해 보입니다
|
위 수정사항 수정했습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoomSetting 과 PaymentList를 만들었습니다.
Layer부분이 연결되는 로직은 아직 구현되지 않았습니다.
action/sagas 부분에 보강이 필요합니다.