Added unit tests for ComBat #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omBat errors for confounded designs and for the output on simulated and the bladder cancer data. 2) Streamlined some of the ComBat errors (just shortened the text). 3) Added myself as a maintainer of the package since I am the only one updating/maintaining the ComBat part of the package.
|
Awesome thanks MN |
jtleek
pushed a commit
that referenced
this pull request
Feb 6, 2016
reference batch ComBat with unit tests
lcolladotor
pushed a commit
that referenced
this pull request
Jun 5, 2017
Commit id: a7cb4b2 Merge pull request #5 from wevanjohnson/master Added unit tests for ComBat Commit id: 7632f0c Made the following changes: 1) added unit tests for ComBat to check ComBat errors for confounded designs and for the output on simulated and the bladder cancer data. 2) Streamlined some of the ComBat errors (just shortened the text). 3) Added myself as a maintainer of the package since I am the only one updating/maintaining the ComBat part of the package. git-svn-id: https://hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@100106 bc3139a8-67e5-0310-9ffc-ced21a209358
lcolladotor
pushed a commit
that referenced
this pull request
Aug 21, 2017
Commit id: a7cb4b2 Merge pull request #5 from wevanjohnson/master Added unit tests for ComBat Commit id: 7632f0c Made the following changes: 1) added unit tests for ComBat to check ComBat errors for confounded designs and for the output on simulated and the bladder cancer data. 2) Streamlined some of the ComBat errors (just shortened the text). 3) Added myself as a maintainer of the package since I am the only one updating/maintaining the ComBat part of the package. git-svn-id: file:///home/git/hedgehog.fhcrc.org/bioconductor/trunk/madman/Rpacks/sva@100106 bc3139a8-67e5-0310-9ffc-ced21a209358
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the following changes: (1) added unit tests for ComBat for the following: (a) check ComBat input errors such as confounded designs,etc, (b) test output on simulated data, and C) test output for the bladder cancer data. (2) Streamlined some of the ComBat errors--just shortened the text. 3) Added myself as a maintainer of the package since I am the only one updating/maintaining the ComBat part of the package (hope this is okay). I ran this through R CMD CHECK and the unit testing works and doesn't encounter any errors (I also 'broke' ComBat in several different ways and the unit tests work well; broken ComBat always results in R CMD CHECK errors).