-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileType
guesstimating needs refactoring
#257
Labels
code improvement
enhancement not seen by the user
difficult
A difficult problem; a major coding effort or difficult algorithm to perfect
P1
important
Comments
jtmoon79
changed the title
file type estimating needs refactoring
Mar 22, 2024
FileType
guesstimating needs refactoring
jtmoon79
added
the
difficult
A difficult problem; a major coding effort or difficult algorithm to perfect
label
Apr 16, 2024
For Issue #16
|
jtmoon79
added a commit
that referenced
this issue
Apr 30, 2024
refactor `enum FileType` to embed archive and storage information in field variant `archival_type` Add variant `encoding_type` for `FileType::Text` refactor `pathbuf_to_filetype` to be more straightforward and recursive entirely remove `Mimeguess` Issue #15 (completed) This part 1 of completing the following issues: Issue #257 Issue #285
jtmoon79
added a commit
that referenced
this issue
Apr 30, 2024
refactor `enum FileType` to embed archive and storage information in field variant `archival_type` Add variant `encoding_type` for `FileType::Text` refactor `pathbuf_to_filetype` to be more straightforward and recursive entirely remove `Mimeguess` Issue #15 (completed) This part 1 of completing the following issues: Issue #257 Issue #285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code improvement
enhancement not seen by the user
difficult
A difficult problem; a major coding effort or difficult algorithm to perfect
P1
important
Summary
file type estimating (guessing) is kind of messy.
Current behavior
MimeGuess
andFileType
is confusing; which one matters when?FileType
guessing is hacky name matchingSuggested behavior
Mimetype
andMimeGuess
entirely (affects BlockReader should receive MimeGuess #15)FileType
based on the file nameIf 1. and 2. are completed then a new Issue should be created around allowing the
filepreprocessor.rs
to read the zero block of the file and do some kind of magic fingerprint matching as well.That change leads to another very large change wherein multiple
FileType
s may be returned during file preprocessing, where the appropriateReader
is attempted and if it fails then the nextReader
is attempted.The text was updated successfully, but these errors were encountered: