teamform: Switch to contributte/multiplier #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
force-pushed
the
contributte-multiplier-2
branch
2 times, most recently
from
3df826e to
2e73698
Compare
`Container::addDynamic` from `Kdyby/Replicator` would only run the closure passed to it after the form is attached.
This is not the case with `contributte/forms-multiplier`, which runs it during creation, which would result in throwing the following `InvalidStateException`:
Component 'registry_address' is not attached to 'Nette\Forms\Form'.
Let’s wait until the form is attached before trying to obtain the input’s id.
`kdyby/replicator` served us well for a long time but unfortunately, it has been unmaintained for a while now. Let’s switch to an actively maintained library. Multiplier manages adding and removing for us and handles default values correctly. Currently, the per-category minimum person limits will not prevent submission.
jtojnar
force-pushed
the
contributte-multiplier-2
branch
from
2e73698 to
420a8e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kdyby/replicatorserved us well for a long time but unfortunately, it has been unmaintained for a while now. Let’s switch to an actively maintained library.Multiplier manages adding and removing for us and handles default values correctly.
Currently, we cannot control per-category person limits at submission.
Supersedes: #58