[ENH]: Complexity features #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omidvarnia
force-pushed
the
complexity_features
branch
from
f70fd6e to
16411a9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
- Coverage 90.04% 89.80% -0.24%
==========================================
Files 90 99 +9
Lines 4118 4367 +249
Branches 811 842 +31
==========================================
+ Hits 3708 3922 +214
- Misses 286 305 +19
- Partials 124 140 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
|
@omidvarnia Can you create one marker per measure? The way it is right now is one marker to rule them all. Junifer's philosophy is to have specific markers with minimal parametrisation. |
omidvarnia
force-pushed
the
complexity_features
branch
from
28fc826 to
754bfa9
Compare
synchon
added
enhancement
synchon
force-pushed
the
complexity_features
branch
3 times, most recently
from
5ab727d to
df5c96e
Compare
synchon
requested changes
Jan 19, 2023
There was a problem hiding this comment.
- The tests are failing for storage and I believe it has something to do with how the marker computation output is being manipulated, would be good if you take a look.
- Would be great if you also take a look at [ENH]: Support for multiple computed masks #175 for handling the mask parameter.
synchon
added
ready
synchon
force-pushed
the
complexity_features
branch
from
d9633f6 to
5ea9195
Compare
synchon
force-pushed
the
complexity_features
branch
from
951f9d0 to
83a2fa5
Compare
synchon
force-pushed
the
complexity_features
branch
from
736a65b to
486c6db
Compare
|
Needs to wait for #269, but should be good for review. |
fraimondo
requested changes
Nov 1, 2023
…opy, permutation entropy, and weighted permutation entropy. To be tested and verified.
…ropy and its weighted version, sample entropy, AUC od multiscale entropy, and Hurst exponent) were added to the Complexity class of markers.
synchon
force-pushed
the
complexity_features
branch
from
eb174fb to
a8fb07d
Compare
…at no runtime funk can happen
|
@fraimondo I've adapted the imports and everything else as we discussed, should be good for a review. I'll fix the tests in the meantime. |
fraimondo
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds seven complexity measures, i.e., range entropy and its AUC, permutation entropy, sample entropy, multiscale entropy and its AUC, and Hurst exponent.