Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add support for ruff linter #229

Merged
merged 13 commits into from
Jun 21, 2023
Merged

update: add support for ruff linter #229

merged 13 commits into from
Jun 21, 2023

Conversation

synchon
Copy link
Member

@synchon synchon commented May 17, 2023

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR adds support for ruff linter and removes isort, flake8 (and extensions) also improving missing linting checks.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #229 (69f8ad1) into main (70eca57) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   93.62%   93.62%   -0.01%     
==========================================
  Files          82       82              
  Lines        3465     3464       -1     
  Branches      650      644       -6     
==========================================
- Hits         3244     3243       -1     
  Misses        144      144              
  Partials       77       77              
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 93.61% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docs/conf.py 100.00% <ø> (ø)
junifer/api/cli.py 69.14% <ø> (ø)
...r/external/nilearn/junifer_nifti_spheres_masker.py 93.40% <ø> (ø)
junifer/markers/reho/reho_estimator.py 68.70% <ø> (ø)
junifer/storage/pandas_base.py 95.55% <ø> (ø)
junifer/api/functions.py 96.23% <100.00%> (ø)
junifer/api/parser.py 94.87% <100.00%> (ø)
junifer/data/coordinates.py 100.00% <100.00%> (ø)
junifer/data/parcellations.py 98.09% <100.00%> (ø)
junifer/datagrabber/base.py 100.00% <100.00%> (ø)
... and 18 more

@github-actions
Copy link

github-actions bot commented May 17, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-06-21 09:44 UTC

@synchon synchon requested a review from fraimondo May 17, 2023 12:57
@synchon synchon changed the title update: simplify linting by adding support for ruff update: add support for ruff linter May 17, 2023
@synchon synchon added enhancement New feature or request ready Pull request is ready for review and merge labels Jun 5, 2023
fraimondo
fraimondo previously approved these changes Jun 20, 2023
fraimondo
fraimondo previously approved these changes Jun 20, 2023
@synchon synchon merged commit 02a14ad into main Jun 21, 2023
@synchon synchon deleted the enh/lint-via-ruff branch June 21, 2023 09:40
@synchon synchon added the maintenance Issues or pull requests related to maintenance label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance Issues or pull requests related to maintenance ready Pull request is ready for review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants