Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Introduce new onthefly sub-module for quick transforms for analyses #237

Merged
merged 11 commits into from
Jul 6, 2023

Conversation

synchon
Copy link
Member

@synchon synchon commented Jun 30, 2023

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR introduces new onthefly sub-module for performing quick transformation of stored data, for further analyses. It intentionally doesn't store the transformed data back as it's cheap to compute and only required for downstream work. For now, it only has one function read_transform() to be used with other third-party libraries (bctpy for now). The docstring of read_transform() provides enough information on using it and also warnings on when it can cause issues. Unit tests are included as well.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #237 (0e4782a) into main (602ea62) will increase coverage by 0.00%.
The diff coverage is 93.93%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   93.57%   93.57%           
=======================================
  Files          82       84    +2     
  Lines        3471     3504   +33     
  Branches      644      648    +4     
=======================================
+ Hits         3248     3279   +31     
- Misses        146      148    +2     
  Partials       77       77           
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 93.57% <93.93%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
junifer/__init__.py 100.00% <ø> (ø)
junifer/onthefly/read_transform.py 93.75% <93.75%> (ø)
junifer/onthefly/__init__.py 100.00% <100.00%> (ø)

@synchon
Copy link
Member Author

synchon commented Jun 30, 2023

Should be merged after #236 .

@synchon synchon requested a review from fraimondo June 30, 2023 11:28
@synchon synchon added the enhancement New feature or request label Jun 30, 2023
Copy link
Contributor

@fraimondo fraimondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs #236 to be merged first. There are changes related to that PR.

pyproject.toml Outdated Show resolved Hide resolved
@synchon synchon added the ready Pull request is ready for review and merge label Jul 3, 2023
@synchon synchon requested a review from fraimondo July 3, 2023 10:30
@synchon synchon force-pushed the feat/transform-module branch from b1d2efa to 0e4782a Compare July 3, 2023 16:04
@synchon synchon merged commit c469049 into main Jul 6, 2023
@synchon synchon deleted the feat/transform-module branch July 6, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready Pull request is ready for review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants