-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: Support for Power 2013
coordinates
#245
Conversation
Codecov Report
@@ Coverage Diff @@
## main #245 +/- ##
==========================================
- Coverage 93.10% 93.05% -0.06%
==========================================
Files 84 84
Lines 3714 3716 +2
Branches 722 723 +1
==========================================
Hits 3458 3458
- Misses 160 161 +1
- Partials 96 97 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a backward's incompatible change. What about a deprecation cycle?
If I remember correctly, we can use functions to "load" coordinates/masks. Or we can implement it in a way that when someone uses "Power" it triggers a deprectation warning during a few release cycles. (We need to define).
That is true. I went with the breaking change as we are still not v1.0.0 . But, I don't mind putting a deprecation notice.
So, I'll put a deprecation notice stating that we'll remove it in the next release. |
Are you requiring a new dataset or marker?
Which feature do you want to include?
We don't yet have the Power 2013 coordinates in-built. This will be a great addition.
How do you imagine this integrated in junifer?
As other in-built coordinates.
Do you have a sample code that implements this outside of junifer?
No response
Anything else to say?
No response