Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Support for Power 2013 coordinates #245

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Conversation

synchon
Copy link
Member

@synchon synchon commented Aug 10, 2023

Are you requiring a new dataset or marker?

  • I understand this is not a marker or dataset request

Which feature do you want to include?

We don't yet have the Power 2013 coordinates in-built. This will be a great addition.

How do you imagine this integrated in junifer?

As other in-built coordinates.

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

@synchon synchon added enhancement New feature or request coordinate Issues or pull requests related to coordinates (ROIs) labels Jul 21, 2023
@synchon synchon added this to the 0.0.4 (alpha 3) milestone Jul 21, 2023
@synchon synchon requested a review from fraimondo August 10, 2023 08:05
@synchon synchon added the ready Pull request is ready for review and merge label Aug 10, 2023
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #245 (fbe18bc) into main (e3e9423) will decrease coverage by 0.06%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
- Coverage   93.10%   93.05%   -0.06%     
==========================================
  Files          84       84              
  Lines        3714     3716       +2     
  Branches      722      723       +1     
==========================================
  Hits         3458     3458              
- Misses        160      161       +1     
- Partials       96       97       +1     
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 93.05% <33.33%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
junifer/data/coordinates.py 95.34% <33.33%> (-4.66%) ⬇️

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://juaml.github.io/junifer/pr-preview/pr-245/
on branch gh-pages at 2023-09-06 09:39 UTC

Copy link
Contributor

@fraimondo fraimondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a backward's incompatible change. What about a deprecation cycle?

If I remember correctly, we can use functions to "load" coordinates/masks. Or we can implement it in a way that when someone uses "Power" it triggers a deprectation warning during a few release cycles. (We need to define).

@synchon
Copy link
Member Author

synchon commented Sep 6, 2023

This is a backward's incompatible change. What about a deprecation cycle?

That is true. I went with the breaking change as we are still not v1.0.0 . But, I don't mind putting a deprecation notice.

If I remember correctly, we can use functions to "load" coordinates/masks. Or we can implement it in a way that when someone uses "Power" it triggers a deprectation warning during a few release cycles. (We need to define).

So, I'll put a deprecation notice stating that we'll remove it in the next release.

@synchon synchon requested a review from fraimondo September 6, 2023 09:35
@synchon synchon merged commit 22ca06f into main Oct 4, 2023
@synchon synchon deleted the feature/power-2013 branch October 4, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coordinate Issues or pull requests related to coordinates (ROIs) enhancement New feature or request ready Pull request is ready for review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants