Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Allow for using venv in queue kind #249

Merged
merged 6 commits into from
Feb 29, 2024
Merged

[ENH]: Allow for using venv in queue kind #249

merged 6 commits into from
Feb 29, 2024

Conversation

synchon
Copy link
Member

@synchon synchon commented Feb 27, 2024

Are you requiring a new dataset or marker?

  • I understand this is not a marker or dataset request

Which feature do you want to include?

Some people do not like to use conda, it would be nice to be able to set the env variable to a path of an environment created using the venv tool to run a junifer pipeline.

How do you imagine this integrated in junifer?

Similar to conda, but with venv.

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

@LeSasse LeSasse added enhancement New feature or request triage New issues waiting to be reviewed labels Aug 10, 2023
@fraimondo fraimondo removed the triage New issues waiting to be reviewed label Feb 21, 2024
@fraimondo fraimondo added this to the 0.0.5 (alpha 4) milestone Feb 21, 2024
Copy link

github-actions bot commented Feb 27, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-02-29 08:34 UTC

@synchon synchon changed the title [ENH]: Allow for using venv to create environments [ENH]: Allow for using venv in queue kind Feb 27, 2024
@synchon synchon requested a review from fraimondo February 27, 2024 16:12
@fraimondo
Copy link
Contributor

You can ask @LeSasse how does he feel about this one too...

@synchon synchon requested a review from LeSasse February 27, 2024 16:38
Copy link
Collaborator

@LeSasse LeSasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this PR is the real MVP. Just a few questions for clarification from my side.

docs/using/queueing.rst Outdated Show resolved Hide resolved
docs/changes/newsfragments/249.feature Show resolved Hide resolved
junifer/api/res/run_venv.sh Show resolved Hide resolved
junifer/api/res/run_venv.sh Outdated Show resolved Hide resolved
@synchon synchon requested a review from LeSasse February 28, 2024 10:57
Copy link
Collaborator

@LeSasse LeSasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge once tests pass I suppose.

@synchon synchon merged commit cf07849 into main Feb 29, 2024
16 of 20 checks passed
@synchon synchon deleted the feat/run-venv branch February 29, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants