[ENH]: Improve BasePreprocessor and fMRIPrepConfoundRemover
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 92.83% 92.82% -0.02%
==========================================
Files 86 86
Lines 3811 3790 -21
Branches 744 741 -3
==========================================
- Hits 3538 3518 -20
+ Misses 170 169 -1
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
fraimondo
approved these changes
Oct 18, 2023
synchon
force-pushed
the
update/preprocessor-base
branch
from
911aa51 to
407978c
Compare
synchon
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors internals of
BasePreprocessorto make it easy for subclassing. It also adaptsfMRIPrepConfoundRemoverto base class changes.