Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Fix FSL std2imgcoord I/O #278

Merged
merged 2 commits into from
Dec 5, 2023
Merged

[BUG]: Fix FSL std2imgcoord I/O #278

merged 2 commits into from
Dec 5, 2023

Conversation

synchon
Copy link
Member

@synchon synchon commented Dec 5, 2023

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR uses the recommended way to bypass the FSL std2imgcoord bug used in coordinates transformation to other template spaces.

@fraimondo
Copy link
Contributor

Will you fix the wrappers here? Otherwise we need another PR.

@synchon synchon requested a review from fraimondo December 5, 2023 10:11
@synchon synchon added the bug Something isn't working label Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #278 (c4218d7) into main (ddfea37) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files          99       99           
  Lines        4390     4390           
  Branches      847      847           
=======================================
  Hits         3928     3928           
  Misses        321      321           
  Partials      141      141           
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
junifer/data/coordinates.py 70.76% <ø> (ø)

Copy link

github-actions bot commented Dec 5, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-12-05 10:24 UTC

@synchon
Copy link
Member Author

synchon commented Dec 5, 2023

Will you fix the wrappers here? Otherwise we need another PR.

Made another PR #279

@synchon synchon merged commit fa74600 into main Dec 5, 2023
20 checks passed
@synchon synchon deleted the fix/std2imgcoord-stdin-bug branch December 5, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants