Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Introduce _AntsApplyTransformsWarper #293

Merged
merged 23 commits into from
Jan 15, 2024
Merged

Conversation

synchon
Copy link
Member

@synchon synchon commented Jan 10, 2024

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR introduces _AntsApplyTransformsWarper as a generic ANTs antsApplyTransforms wrapper class for internal use. It also adapts BOLDWarper, get_mask, get_parcellation and get_coordinates to dynamically choose FSL or ANTs depending on warp file extension. It also completes unit tests for _ApplyWarper and BOLDWarper.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 108 lines in your changes are missing coverage. Please review.

Comparison is base (4f42f76) 89.46% compared to head (9c0b219) 88.09%.

❗ Current head 9c0b219 differs from pull request most recent head 150871a. Consider uploading reports for the commit 150871a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
- Coverage   89.46%   88.09%   -1.37%     
==========================================
  Files          98       99       +1     
  Lines        4405     4512     +107     
  Branches      847      865      +18     
==========================================
+ Hits         3941     3975      +34     
- Misses        323      396      +73     
  Partials      141      141              
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 88.09% <17.55%> (-1.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
junifer/preprocess/fsl/apply_warper.py 38.46% <ø> (ø)
junifer/preprocess/bold_warper.py 54.83% <9.09%> (-17.89%) ⬇️
junifer/data/masks.py 75.49% <4.76%> (-7.47%) ⬇️
junifer/data/parcellations.py 86.27% <4.76%> (-2.32%) ⬇️
junifer/data/coordinates.py 56.09% <0.00%> (-14.68%) ⬇️
...er/preprocess/ants/ants_apply_transforms_warper.py 38.46% <38.46%> (ø)

... and 3 files with indirect coverage changes

@synchon synchon force-pushed the update/add-ants-warping branch from 49e5927 to 8e72e8e Compare January 10, 2024 10:08
Copy link

github-actions bot commented Jan 10, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-01-15 09:08 UTC

@synchon synchon added enhancement New feature or request ready Pull request is ready for review and merge parcellation Issues or pull requests related to parcellations (atlases) coordinate Issues or pull requests related to coordinates (ROIs) mask Issues or pull requests related to masks labels Jan 10, 2024
@synchon synchon requested a review from fraimondo January 10, 2024 11:02
@synchon synchon force-pushed the update/add-ants-warping branch from c3fdabc to c283f14 Compare January 12, 2024 10:21
@synchon synchon force-pushed the update/add-ants-warping branch from 9c0b219 to 150871a Compare January 15, 2024 08:46
@synchon synchon merged commit 69ebbcd into main Jan 15, 2024
17 of 20 checks passed
@synchon synchon deleted the update/add-ants-warping branch January 15, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coordinate Issues or pull requests related to coordinates (ROIs) enhancement New feature or request mask Issues or pull requests related to masks parcellation Issues or pull requests related to parcellations (atlases) ready Pull request is ready for review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants