Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Introduce run_ext_cmd for running external commands #295

Merged
merged 12 commits into from
Jan 16, 2024

Conversation

synchon
Copy link
Member

@synchon synchon commented Jan 15, 2024

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR introduces a helper function run_ext_cmd to run external commands like those from FSL, ANTs and others.

@synchon synchon added the enhancement New feature or request label Jan 15, 2024
@synchon synchon requested a review from fraimondo January 15, 2024 12:57
Copy link

github-actions bot commented Jan 15, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-01-16 11:17 UTC

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (69ebbcd) 88.11% compared to head (ed448c4) 89.23%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   88.11%   89.23%   +1.12%     
==========================================
  Files          99      100       +1     
  Lines        4517     4449      -68     
  Branches      865      853      -12     
==========================================
- Hits         3980     3970      -10     
+ Misses        396      341      -55     
+ Partials      141      138       -3     
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 89.23% <72.72%> (+1.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
junifer/markers/falff/falff_estimator.py 95.50% <100.00%> (+1.56%) ⬆️
junifer/markers/reho/reho_estimator.py 68.30% <100.00%> (+0.12%) ⬆️
junifer/utils/__init__.py 100.00% <100.00%> (ø)
junifer/utils/helpers.py 100.00% <100.00%> (ø)
junifer/data/coordinates.py 63.38% <33.33%> (+7.28%) ⬆️
junifer/data/masks.py 81.37% <33.33%> (+5.09%) ⬆️
junifer/data/parcellations.py 88.16% <33.33%> (+1.89%) ⬆️
...er/preprocess/ants/ants_apply_transforms_warper.py 47.50% <25.00%> (+9.03%) ⬆️
junifer/preprocess/fsl/apply_warper.py 47.50% <25.00%> (+9.03%) ⬆️

@synchon synchon merged commit 4acf8b2 into main Jan 16, 2024
19 of 20 checks passed
@synchon synchon deleted the chore/run_ext_cmd-helper branch January 16, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants