Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI]: Improve CI #318

Merged
merged 15 commits into from
Jun 21, 2024
Merged

[CI]: Improve CI #318

merged 15 commits into from
Jun 21, 2024

Conversation

synchon
Copy link
Member

@synchon synchon commented Jun 18, 2024

The CI is acting up due to AFNI tests failing (ReHo and (f)ALFF) and FSL not being installed correctly. Although the latter is being avoided now, the former is not and thus coverage is not being reported. We need to come up with a flexible solution to handle situations like this.

@synchon synchon added the maintenance Issues or pull requests related to maintenance label Apr 3, 2024
@synchon synchon added this to the 0.0.5 (alpha 4) milestone Apr 3, 2024
@synchon synchon self-assigned this Apr 3, 2024
Copy link

github-actions bot commented Jun 18, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-21 09:17 UTC

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (b890e54) to head (8d0956c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##              main     #318       +/-   ##
============================================
- Coverage   100.00%   86.64%   -13.36%     
============================================
  Files            1      114      +113     
  Lines            1     5137     +5136     
  Branches         0      999      +999     
============================================
+ Hits             1     4451     +4450     
- Misses           0      528      +528     
- Partials         0      158      +158     
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
junifer/markers/brainprint.py 40.94% <100.00%> (ø)
junifer/markers/falff/_afni_falff.py 37.83% <ø> (ø)
junifer/markers/reho/_afni_reho.py 35.89% <ø> (ø)
junifer/pipeline/pipeline_step_mixin.py 97.72% <100.00%> (ø)
junifer/preprocess/smoothing/_afni_smoothing.py 39.13% <ø> (ø)
junifer/utils/logging.py 72.00% <100.00%> (ø)

... and 107 files with indirect coverage changes

@synchon synchon requested a review from fraimondo June 20, 2024 14:25
@synchon synchon merged commit 531589d into main Jun 21, 2024
19 of 23 checks passed
@synchon synchon deleted the chore/fix-ci branch June 21, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues or pull requests related to maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants