-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: Move data downloading/handling to junifer-data
package.
#363
Open
synchon
wants to merge
31
commits into
main
Choose a base branch
from
refactor/junifer-data-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraimondo
added
enhancement
New feature or request
triage
New issues waiting to be reviewed
labels
Sep 24, 2024
fraimondo
changed the title
[ENH]: Move data downlading/handling to
[ENH]: Move data downloading/handling to Sep 24, 2024
junifer-data
package.junifer-data
package.
…init and registration logic for ParcellationRegistry
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
======================================
Coverage 0.01% 0.01%
======================================
Files 133 133
Lines 5764 5558 -206
======================================
Hits 1 1
+ Misses 5763 5557 -206
Flags with carried forward coverage won't be shown. Click here to find out more.
|
synchon
added
parcellation
Issues or pull requests related to parcellations (atlases)
coordinate
Issues or pull requests related to coordinates (ROIs)
mask
Issues or pull requests related to masks
labels
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
coordinate
Issues or pull requests related to coordinates (ROIs)
enhancement
New feature or request
mask
Issues or pull requests related to masks
parcellation
Issues or pull requests related to parcellations (atlases)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you requiring a new dataset or marker?
Which feature do you want to include?
Currently, Junifer is handling the data, downloading from various sources. Ideally, this should be centralized and versiones.
How do you imagine this integrated in junifer?
junifer-data
API.junifer-data
keeps a datalad dataset with all data objects, including externals. Each commit to this datasets has a tag.junifer
knows exactly which is the tag that we are dealing with, so each junifer version will always work with the same data files.download
or similar that makes junifer download all (or the requested) files to be used later on with therun
command.Do you have a sample code that implements this outside of junifer?
No response
Anything else to say?
No response