Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Fix metadata update for MultipleDataGrabber #398

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

synchon
Copy link
Member

@synchon synchon commented Nov 19, 2024

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR fixes metadata update for MultipleDataGrabber and refactors PatternDataGrabber.get_elements() to check list-like data type values.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (3a05a93) to head (92bbd72).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   87.10%   87.07%   -0.04%     
==========================================
  Files         129      129              
  Lines        4995     4966      -29     
  Branches      827      817      -10     
==========================================
- Hits         4351     4324      -27     
  Misses        474      474              
+ Partials      170      168       -2     
Flag Coverage Δ
docs 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/datagrabber/multiple.py 89.79% <ø> (-0.41%) ⬇️
junifer/datagrabber/pattern.py 97.40% <ø> (+1.24%) ⬆️
junifer/datagrabber/pattern_validation_mixin.py 97.72% <ø> (ø)
---- 🚨 Try these New Features:

Copy link

github-actions bot commented Nov 19, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-21 13:26 UTC

@synchon synchon added bug Something isn't working dataset Issues or pull requests related to datagrabbers or datasets labels Nov 20, 2024
@synchon synchon added this to the 0.0.6 (alpha 5) milestone Nov 20, 2024
@synchon synchon requested a review from fraimondo November 20, 2024 12:35
@synchon synchon merged commit 1944462 into main Nov 21, 2024
18 of 23 checks passed
@synchon synchon deleted the fix/multiple-dg-meta-update branch November 21, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dataset Issues or pull requests related to datagrabbers or datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants