Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Simplify space warping for parcellations and masks #414

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

synchon
Copy link
Member

@synchon synchon commented Dec 6, 2024

  • description of feature/fix
  • tests added/passed
  • add an entry for the latest changes

This PR simplifies space warping for parcellations and masks.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 0.01%. Comparing base (12ecdb2) to head (c93d589).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
junifer/data/masks/_masks.py 0.00% 9 Missing ⚠️
junifer/data/parcellations/_parcellations.py 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #414   +/-   ##
=====================================
  Coverage   0.01%   0.01%           
=====================================
  Files        133     133           
  Lines       5719    5718    -1     
=====================================
  Hits           1       1           
+ Misses      5718    5717    -1     
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
junifer/data/parcellations/_parcellations.py 0.00% <0.00%> (ø)
junifer/data/masks/_masks.py 0.00% <0.00%> (ø)

@synchon synchon force-pushed the fix/non-native-data-warping branch from 8828259 to 95427f1 Compare December 6, 2024 12:52
@synchon synchon requested a review from fraimondo December 6, 2024 12:55
Copy link

github-actions bot commented Dec 6, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://juaml.github.io/junifer/pr-preview/pr-414/
on branch gh-pages at 2024-12-09 11:28 UTC

@synchon synchon added enhancement New feature or request parcellation Issues or pull requests related to parcellations (atlases) mask Issues or pull requests related to masks template-space Issues or pull requests related to template spaces labels Dec 9, 2024
@synchon synchon added this to the 0.0.6 (alpha 5) milestone Dec 9, 2024
@synchon synchon merged commit 69275b2 into main Dec 9, 2024
18 of 21 checks passed
@synchon synchon deleted the fix/non-native-data-warping branch December 9, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mask Issues or pull requests related to masks parcellation Issues or pull requests related to parcellations (atlases) template-space Issues or pull requests related to template spaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants