-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for spheres-based functional connectivity #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraimondo
force-pushed
the
feat/marker_fc_sphere_issue41
branch
2 times, most recently
from
September 15, 2022 11:08
496a272
to
6df99e1
Compare
4 tasks
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 87.63% 87.88% +0.25%
==========================================
Files 48 49 +1
Lines 1819 1857 +38
Branches 336 339 +3
==========================================
+ Hits 1594 1632 +38
Misses 180 180
Partials 45 45
|
synchon
changed the title
Feat/marker fc sphere issue41
feat: add support for spheres-based functional connectivity
Oct 6, 2022
synchon
force-pushed
the
feat/marker_fc_sphere_issue41
branch
from
October 6, 2022 06:43
242c5a4
to
906b8c0
Compare
synchon
requested changes
Oct 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor changes.
@synchon your call now |
synchon
force-pushed
the
feat/marker_fc_sphere_issue41
branch
from
October 7, 2022 09:58
e3bbd1a
to
d8e3c83
Compare
synchon
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spheres based FC