Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for spheres-based functional connectivity #78

Merged
merged 10 commits into from
Oct 7, 2022

Conversation

kaurao
Copy link
Collaborator

@kaurao kaurao commented Sep 14, 2022

Spheres based FC

@fraimondo fraimondo self-assigned this Sep 15, 2022
@fraimondo fraimondo force-pushed the feat/marker_fc_sphere_issue41 branch 2 times, most recently from 496a272 to 6df99e1 Compare September 15, 2022 11:08
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #78 (d8e3c83) into main (91fc853) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   87.63%   87.88%   +0.25%     
==========================================
  Files          48       49       +1     
  Lines        1819     1857      +38     
  Branches      336      339       +3     
==========================================
+ Hits         1594     1632      +38     
  Misses        180      180              
  Partials       45       45              
Impacted Files Coverage Δ
junifer/markers/functional_connectivity_spheres.py 100.00% <100.00%> (ø)

@fraimondo fraimondo requested a review from synchon October 5, 2022 15:03
@synchon synchon changed the title Feat/marker fc sphere issue41 feat: add support for spheres-based functional connectivity Oct 6, 2022
@synchon synchon force-pushed the feat/marker_fc_sphere_issue41 branch from 242c5a4 to 906b8c0 Compare October 6, 2022 06:43
Copy link
Member

@synchon synchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes.

junifer/markers/functional_connectivity_spheres.py Outdated Show resolved Hide resolved
junifer/markers/functional_connectivity_spheres.py Outdated Show resolved Hide resolved
junifer/markers/functional_connectivity_spheres.py Outdated Show resolved Hide resolved
junifer/markers/functional_connectivity_spheres.py Outdated Show resolved Hide resolved
junifer/markers/functional_connectivity_spheres.py Outdated Show resolved Hide resolved
@fraimondo
Copy link
Contributor

@synchon your call now

@synchon synchon force-pushed the feat/marker_fc_sphere_issue41 branch from e3bbd1a to d8e3c83 Compare October 7, 2022 09:58
Copy link
Member

@synchon synchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@synchon synchon merged commit 2bc117a into juaml:main Oct 7, 2022
@fraimondo fraimondo deleted the feat/marker_fc_sphere_issue41 branch October 7, 2022 10:14
@synchon synchon added the marker Issues or pull requests related to markers label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marker Issues or pull requests related to markers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MARKER]: Functional Connectivity
3 participants