Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add percentiles to summary output #59

Merged
merged 3 commits into from
Feb 10, 2024
Merged

Conversation

JackKCWong
Copy link
Contributor

image

I change the Stat::new to mutable borrow the input vec to avoid copying, except for the xyplot where original order matters. Let me know what you think. Cheers.

@JackKCWong
Copy link
Contributor Author

tests passed.
image

@juan-leon
Copy link
Owner

juan-leon commented Feb 9, 2024

Thanks for the pull request. Having percentiles is nice.

The Test pipeline failed (it seems fixable with cargo fmt).

If you have make tool installed you can do make pre-commit to make sure changes are OK. Otherwise, this will do the job:

cargo fmt -- --check
cargo test -- --test-threads 1
cargo clippy -- -D clippy::all

@JackKCWong
Copy link
Contributor Author

cargo fmt -- --check

Should have run make pre-commit! Fixed now. Thanks.

@juan-leon juan-leon merged commit f78c799 into juan-leon:main Feb 10, 2024
1 check passed
@juan-leon
Copy link
Owner

Excellent!

Thanks for your contribution

@juan-leon
Copy link
Owner

Created release v0.5.9 with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants