Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate collecting and visiting of the product id helpers. #1

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Separate collecting and visiting of the product id helpers. #1

merged 1 commit into from
Dec 1, 2023

Conversation

s-l-teichmann
Copy link

There may be use case where we just want to visit the helpers w/o stuffing them in a slice.

@s-l-teichmann s-l-teichmann mentioned this pull request Nov 30, 2023
Merged
juan131
juan131 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Owner

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the improvement

@juan131 juan131 merged commit 181d2d0 into juan131:feat/find-product-id-helpers Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan131 juan131 juan131 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-l-teichmann @juan131