Skip to content

Commit

Permalink
worker: handle detached MessagePort from a different context
Browse files Browse the repository at this point in the history
When `worker.moveMessagePortToContext` is used, the async handle
associated with the port, will be triggered more than needed (at least
one more time) and with null data. That can be avoided by simply
checking that the data is present and the port is not detached.

Fixes: nodejs#49075
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
  • Loading branch information
juanarbol committed Aug 13, 2023
1 parent 6432060 commit 36978ae
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/node_messaging.cc
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,11 @@ void MessagePort::OnMessage(MessageProcessingMode mode) {

size_t processing_limit;
if (mode == MessageProcessingMode::kNormalOperation) {
// Maybe the async handle was triggered empty or more than needed
// (called twiced on a new context).
if (GetTransferMode() == TransferMode::kDisallowCloneAndTransfer || !data_)
return;

Mutex::ScopedLock(data_->mutex_);
processing_limit = std::max(data_->incoming_messages_.size(),
static_cast<size_t>(1000));
Expand Down

0 comments on commit 36978ae

Please sign in to comment.