-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] OIDC with permanent ID #1990
Comments
Maybe not |
I believe this PR is attempting to add support for |
I think |
I do not think this is actually fixed by #2020, because the always-active fallback behaviour will still allow account take-overs, even if the target account has been "updated" to use the |
This commit hardens the migration part of the OIDC from the old username based approach to the new sub based approach and makes it possible for the operator to opt out entirely. Fixes juanfont#1990 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This commit hardens the migration part of the OIDC from the old username based approach to the new sub based approach and makes it possible for the operator to opt out entirely. Fixes juanfont#1990 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This commit hardens the migration part of the OIDC from the old username based approach to the new sub based approach and makes it possible for the operator to opt out entirely. Fixes juanfont#1990 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This commit hardens the migration part of the OIDC from the old username based approach to the new sub based approach and makes it possible for the operator to opt out entirely. Fixes juanfont#1990 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This commit hardens the migration part of the OIDC from the old username based approach to the new sub based approach and makes it possible for the operator to opt out entirely. Fixes juanfont#1990 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This commit hardens the migration part of the OIDC from the old username based approach to the new sub based approach and makes it possible for the operator to opt out entirely. Fixes juanfont#1990 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This commit hardens the migration part of the OIDC from the old username based approach to the new sub based approach and makes it possible for the operator to opt out entirely. Fixes juanfont#1990 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This commit hardens the migration part of the OIDC from the old username based approach to the new sub based approach and makes it possible for the operator to opt out entirely. Fixes #1990 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Use case
Currently, if user account in external system might have an email or username changed, OIDC authentication in Headscale won't match an existing user in DB, and another user will be created instead.
Description
Use OIDC
sub
claim as a permanent identifier for a userIf we use
sub
claim as a permanent unique ID for a user, we can match OIDC authenticated user with it instead of a username, and update a username (email) in DB if it differs. We should make updating optional as ACLs might stop applying to affected users.Use and save OIDC
email
claim regardless of email domain strippingA discussion is probably needed.
![Screenshot 2024-06-22 at 5 21 29 PM](https://private-user-images.githubusercontent.com/80180243/341974128-56a8d96e-2c39-4be6-a16a-c5b63e76691e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMTA1NDQsIm5iZiI6MTczOTMxMDI0NCwicGF0aCI6Ii84MDE4MDI0My8zNDE5NzQxMjgtNTZhOGQ5NmUtMmMzOS00YmU2LWExNmEtYzViNjNlNzY2OTFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDIxNDQwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdhMzkyOTkxYzNjYTk2ZjY2M2U4NDljMzkzMTNlMDcxOWQ2MGRhMjI5ZDU3ZmRmMTAzODNhYmY3NzUwZjdkMGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.9JTjjs_T76jvRZm9NEVcYZkD2BQxu5XWkRNlftsKz68)
email
, if available, could be used to display asLoginName
in Tailscale clients. Or, it could be another way to identify users in ACLs ifstrip_email_domain
is turned on, particularly, to avoid username collisions if multiple domains are allowed to login.But considering #1987, we might not need to strip email domains anymore.
Contribution
The text was updated successfully, but these errors were encountered: