Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Latest config example contains deprecated key #2219

Closed
2 of 4 tasks
sevenrats opened this issue Nov 1, 2024 · 4 comments · Fixed by #2279
Closed
2 of 4 tasks

[Bug] Latest config example contains deprecated key #2219

sevenrats opened this issue Nov 1, 2024 · 4 comments · Fixed by #2279
Labels
bug Something isn't working
Milestone
v0.24.0

Comments

@sevenrats
Copy link

Is this a support request?

  • This is not a support request

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

current conf example does not match latest spec

Expected Behavior

match the latest spec

Steps To Reproduce

use the example conf file. it has a deprecated key.

Environment

latest bookworm

Runtime environment

  • Headscale is behind a (reverse) proxy
  • Headscale runs in a container

Anything else?

No response
@sevenrats sevenrats added the bug Something isn't working label Nov 1, 2024
@kradalby
Copy link
Collaborator

Sorry, can you elaborate on which key is wrong?

@teleclimber
Copy link

Not the OP but if I were to guess: they are seeing this in their logs:

WARN: The "dns.use_username_in_magic_dns" configuration key is deprecated and has been removed. Please see the changelog...

Which presumably is due to the key being explicitly set to false in the current default config:

  # DEPRECATED
  # Use the username as part of the DNS name for nodes, with this option enabled:
  # node1.username.example.com
  # while when this is disabled:
  # node1.example.com
  # This is a legacy option as Headscale has have this wrongly implemented
  # while in upstream Tailscale, the username is not included.
  use_username_in_magic_dns: false

@sevenrats
Copy link
Author

iirc there were one or three I had to fix to get main working. sorry for incomplete report, I think I intended to self-assign when I opened this.

@sevenrats
Copy link
Author

"dns.use_username_in_magic_dns"

nblock added a commit to nblock/headscale that referenced this issue Dec 11, 2024
@nblock
Remove use_username_in_magic_dns option
5a89b3a 
Upgrade the use of dns.use_username_in_magic_dns or
dns_config.use_username_in_magic_dns to a fatal error and remove the
option from the example configuration and integration tests.

Fixes: juanfont#2219
@nblock nblock mentioned this issue Dec 11, 2024
Merged
6 tasks
nblock added a commit to nblock/headscale that referenced this issue Dec 11, 2024
@nblock
Remove use_username_in_magic_dns option
76aa981 
Upgrade the use of dns.use_username_in_magic_dns or
dns_config.use_username_in_magic_dns to a fatal error and remove the
option from the example configuration and integration tests.

Fixes: juanfont#2219
nblock added a commit to nblock/headscale that referenced this issue Dec 11, 2024
@nblock
Remove use_username_in_magic_dns option
0acd0b2 
Upgrade the use of dns.use_username_in_magic_dns or
dns_config.use_username_in_magic_dns to a fatal error and remove the
option from the example configuration and integration tests.

Fixes: juanfont#2219
nblock added a commit that referenced this issue Dec 11, 2024
@nblock
Remove use_username_in_magic_dns option
89a648c 
Upgrade the use of dns.use_username_in_magic_dns or
dns_config.use_username_in_magic_dns to a fatal error and remove the
option from the example configuration and integration tests.

Fixes: #2219
@nblock nblock added this to the v0.24.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.24.0
Development

Successfully merging a pull request may close this issue.

Remove use_username_in_magic_dns option nblock/headscale
4 participants
@kradalby @nblock @teleclimber @sevenrats