Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integration tests #114

Merged
merged 5 commits into from
Sep 22, 2021

Conversation

kradalby
Copy link
Collaborator

@kradalby kradalby commented Sep 20, 2021

This PR expands the integration tests:

  • Tailscale version support (list with available versions in apt)
  • Stability and neating up a bit (use json output and proper datatypes)
  • Initial support for testing shared nodes (no ping yet)

This commit adds a list of tailscale versions to use in the integration
test. An equal distribution of versions will be used across the clients.
This expands the tests to verify two namespaces instead of only one.

It verifies some of the isolation, and is prework for shared nodes
testing
This commit uses tailscale --json to check status, and unmarshal it into
the proper ipn Status.
This commit adds initial integration tests for shared nodes, it adds
them and verifies that they are shared.

It does not yet manage to ping the shared node because it does not seem
to establish the connection.
@kradalby kradalby marked this pull request as ready for review September 20, 2021 22:32
@kradalby kradalby requested a review from juanfont September 20, 2021 22:34
Copy link
Owner

@juanfont juanfont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job!

@juanfont juanfont merged commit 96e8142 into juanfont:main Sep 22, 2021
@kradalby kradalby deleted the integration-tests-improvement branch March 2, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants