refactor: Support any PostgreSQL database #1348
Conversation
|
Just curious, what options did cockroachDB require that aren't currently provided? What does the db url string you use look like? |
| @@ -122,6 +122,11 @@ func NewHeadscale(cfg *Config) (*Headscale, error) { | |||
| var dbString string | |||
| switch cfg.DBtype { | |||
| case Postgres: | |||
| if cfg.DBurl != "" { | |||
There was a problem hiding this comment.
Any particular reason for this to only apply to Postgres? This seems like this could be a generic feature to override DBURL for any DBType
| @@ -61,6 +61,7 @@ type Config struct { | |||
| DBuser string | |||
| DBpass string | |||
| DBssl string | |||
| DBurl string | |||
There was a problem hiding this comment.
| DBurl string | |
| // DBurl explicitly sets the url passed to the database driver | |
| // If set, DBpath, DBhost, DBport, DBname, DBuser, DBpass, DBssl is ignored | |
| DBurl string |
|
Hi! as part of #1473, we have reorganised a lot of the code. To clear PRs that needs to be rebased or redone, we are closing open PRs that will require significant code change to be merged. In addition, the issue of the PR might in some cases have been fixed, change or no longer relevant, so it would be great if this is considered as well. Thank you for your contribution! If it is still relevant and the PR is reopened, we will aim at getting the changes into the next release after the reorg if accepted. |
We wanted to use CockroachDB with headscale, which was not possible with the current config options. This PR adds support to directly input a Postgres dialect URL