Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code reorg part 3 #1477

Merged
merged 13 commits into from
Jun 8, 2023
Merged

Code reorg part 3 #1477

merged 13 commits into from
Jun 8, 2023

Conversation

kradalby
Copy link
Collaborator

@kradalby kradalby commented May 26, 2023

  1. Split and potentially rewrite hscontrol into packages (this might change) (Code reorg part 3 #1477)
  • mapper, all code related to generating MapResponses (the map clients need to find their peers)
  • api, the code that implements our gRPC interface (For now, leave grpc in root)
  • derp, derp related code
  • dns, related code

@kradalby kradalby force-pushed the corereorg-p3 branch 2 times, most recently from 3514528 to de1c608 Compare May 30, 2023 17:33
@kradalby kradalby changed the title Code reorg part 3: More modules Code reorg part 3: move map response to own module Jun 5, 2023
@kradalby kradalby closed this Jun 5, 2023
@kradalby kradalby reopened this Jun 5, 2023
@kradalby kradalby marked this pull request as ready for review June 5, 2023 14:42
@kradalby kradalby requested a review from juanfont as a code owner June 5, 2023 14:42
@kradalby kradalby closed this Jun 5, 2023
@kradalby kradalby reopened this Jun 5, 2023
kradalby added 6 commits June 5, 2023 21:18
The mapper package contains functions related to creating and marshalling
reponses to machines.

Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Prior to the code reorg, we would generate rules from the Policy and
store it on the global object. Now we generate it on the fly for each node
and this commit cleans up the old variables to make sure we have no
unexpected side effects.

Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby kradalby marked this pull request as draft June 6, 2023 08:03
@kradalby kradalby changed the title Code reorg part 3: move map response to own module Code reorg part 3 Jun 6, 2023
@kradalby kradalby mentioned this pull request Jun 6, 2023
6 tasks
kradalby added 6 commits June 6, 2023 17:15
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This commit renames a bunch of files to try to make it a bit less confusing;

protocol_ is now auth as they contained registration, auth and login/out flow
protocol_.*_poll is now poll.go
api.go and other generic handlers are now handlers.go

Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby kradalby marked this pull request as ready for review June 6, 2023 15:18
@kradalby kradalby merged commit 0562260 into juanfont:main Jun 8, 2023
@kradalby kradalby deleted the corereorg-p3 branch June 8, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants